read_attribute_str returns cleanly when found=F #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates read_attribute_str() so that if the optional argument found is provided and the attribute is not defined, then the function returns with found=.false. instead of calling MOM_error(FATAL). I did a little bit of testing, and it looks like read_attribute_real and read_attribute_int (not sure if the default is int32 or int64) already behave correctly when found is present so they do not need a similar update
Hallberg-NOAA
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
I have reviewed the logic here, and I am convinced that this is correct and that is should neatly correct the problem noted in issue #1375.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
read_attribute_str()so that if the optional argument found is providedand the attribute is not defined, then the function returns with
found=.false.instead of calling
MOM_error(FATAL).I did a little bit of testing, and it looks like
read_attribute_realandread_attribute_int(not sure if the default is int32 or int64) already behavecorrectly when
foundis present so they do not need a similar updateFixes #1375