Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+Correct the units of remap tendency diagnostics #1382

Merged

Conversation

Hallberg-NOAA
Copy link
Collaborator

Corrected the units of the ..._h_tendency_vert_remap diagnostics and their
2-d counterparts to reflect the fact that they are integrated tendencies,
addressing MOM6 issue #1017. This PR changes the units of several variables in
the available_diags files and any output files with these diagnostics.

Also eliminated the spacing around the equal sign in a number of optional
argument declarations in this file to follow the MOM6 standards in the MOM6
style guide. Also changed some irregular continuation line indents for
self-consistency in register_tracer_diagnostics.

All answers are bitwise identical, but there are minor metadata changes in
some output files.

  Corrected the units of the ..._h_tendency_vert_remap diagnostics and their
2-d counterparts to reflect the fact that they are integrated tendencies,
addressing MOM6 issue mom-ocean#1017.  This PR changes the units of several variables in
the available_diags files and any output files with these diagnostics.

  Also eliminated the spacing around the equal sign in a number of optional
argument declarations in this file to follow the MOM6 standards in the MOM6
style guide.  Also changed some irregular continuation line indents for
self-consistency in register_tracer_diagnostics.

  All answers are bitwise identical, but there are minor metadata changes in
some output files.
@StephenGriffies
Copy link
Contributor

I approve. Thanks @Hallberg-NOAA

@marshallward
Copy link
Collaborator

marshallward commented Apr 27, 2021

@marshallward marshallward merged commit b5619c8 into mom-ocean:dev/gfdl Apr 27, 2021
@Hallberg-NOAA Hallberg-NOAA deleted the heat_remap_diag_units branch July 30, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants