Ice dynamics #1387
Ice dynamics #1387
Conversation
dev/gfdl updates
Merge branch 'ice_dynamics' of https://github.com/OlgaSergienko/MOM6 into ice_dynamics
…tten for that grid.
| @@ -425,19 +429,19 @@ subroutine initialize_ice_shelf_dyn(param_file, Time, ISS, CS, G, US, diag, new_ | |||
| ! previously allocated for registration for restarts. | |||
|
|
|||
| if (active_shelf_dynamics) then | |||
| allocate( CS%u_bdry_val(Isdq:Iedq,Jsdq:Jedq) ) ; CS%u_bdry_val(:,:) = 0.0 | |||
There was a problem hiding this comment.
All of these memory declarations are problematic, and would not work for variables on a C-grid with symmetric memory. See the comment about about CS%u_shelf and CS%v_shelf for guidance on how to fix it.
a new subroutine (initialize_ice_shelf_boundary_from_file) in MOM_ice_shelf_initialize.F90 to read b.c.s from file
There was a problem hiding this comment.
Upon visual inspection, everything here seems like it could be OK, although we do not have a test case that exercises this code. Because this code is still under development, I think that this can be safely approved, but with the awareness that there may be additional updates that change answers in some instances before this code is finalized or put into regular use.
|
This PR just passed the pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12662. |
This PR includes modifications for MOM_ice_shelf_dynamics.F90 that allows for runs with both symmetric and non-symmetric memory. MOM_ice_shelf_initialize.F90 includes a new subroutine
initialize_ice_shelf_boundary_from_filethat reads ice-shelf velocity boundary conditions (values, masks, etc).A test case for a symmetric case is
/lustre/f2/dev/gfdl/Olga.Sergienko/MOM6expls/ocean_only/ice_shelf_solo/IS2Dincl_plane_layer_sym/
A test case fro a non-symmetric case is
/lustre/f2/dev/gfdl/Olga.Sergienko/MOM6expls/ocean_only/ice_shelf_solo/IS2Dincl_plane_layer/