+Add dimensional rescaling of wave variables #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added dimensional rescaling for all of the variables in the MOM_wave, including rescaling of the Stokes velocities, which are used in two modules outside of the MOM_wave_interface module. Also added comments describing numerous variables inside of the wave module, and removed the public declaration for most of the elements of the wave_parameters_CS. All answers are bitwise identical in tests, but the waves module is not as extensively tested as it should be. There are changes in the rescaled units in publicly visible variables.
breichl
approved these changes
May 18, 2021
marshallward
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dimensional rescaling for all of the variables in the MOM_wave code,
including rescaling of the Stokes velocities, which are used in two modules
outside of the MOM_wave_interface module. Also added comments describing
numerous variables inside of the wave module, and removed the public declaration
for most of the elements of the wave_parameters_CS. All answers are bitwise
identical in tests, but the waves module is not as extensively tested as it
should be. There are changes in the rescaled units in publicly visible
variables. The commits in this PR include: