Trying to fix Kelvin wave boundary condition. #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kshedstrom
commented
May 21, 2021
kshedstrom
commented
- Better, but doesn't quite pass RESCALE tests.
- Better, but doesn't quite pass RESCALE tests.
Hallberg-NOAA
added a commit
to Hallberg-NOAA/MOM6
that referenced
this pull request
May 25, 2021
Add dimensional rescaling of user OBC test cases, including documentation of the units of variables in the Kelvin, shelfwave, tidal_bay and dyed_channel initialization and rescaling parameters parameters via optional scale arguments to get_param calls. These changes also incorporate the answer-changing correction to the Kelvin wave OBC test case in PR mom-ocean#1406, with a comment noting what seems like an additional bug in this test case. This commit includes adding a unit_scale_type argument to call_OBC_register, register_file_OBC, register_tidal_bay_OBC, register_Kelvin_OBC, register_shelfwave_OBC and register_dyed_channel_OBC. These Kelvin wave OBC configuration from ESMG-configs now passes the dimensional rescaling tests. All answers are bitwise identical in the MOM6_examples test cases, but there are interface changes.
Hallberg-NOAA
approved these changes
May 26, 2021
There was a problem hiding this comment.
I agree that these changes are correct. The problems with the dimensional scaling tests that are noted in the description of this PR is addressed in the subsequent PR #1411.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.