update halo and allow sponge_uv to not be on grid #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abozec
commented
Jun 21, 2021
abozec
commented
- update Iresttime, data_h and h halos for sponge_uv reproducibility
- add condition to not be on grid for sponge_uv
- update Iresttime, data_h and h halos for sponge_uv reproducibility - add condition to not be on grid for sponge_uv
|
Line 844 got messed up somehow. I agree that the pass_var of h is needed. |
|
thank you for catching that, I've corrected the line. |
Hallberg-NOAA
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
I agree with these changes, and they have passed TC testing and pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12956.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.