Solution to UV sponge restarts #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for the u,v sponges to be invariant of tiling. I don't know why, but the problem only showed up for me in a narrow channel in the Bering domain.
The MOM_control_struct is declared and passed as a pointer to a CS (usually allocated anonymously) and treated as if it were a pointer, even though there is currently no real advantage to doing so. After the FMS update, the deallocation of this CS was causing a segmentation fault in the PGI compilers. While the underlying cause was never determined, it is likely due to some automated deallocation of the CS contents, whose addressing became scrambled. This problem can be resolved by moving all of the CS contents to stack, so that the contents are automatically removed upon exiting whatever function it was instantiated. Subsequent calls can reference the local (or parent) stack contents.
- Without this change, the edges don't reproduce on restart due to the h values outside being nonsense.
|
This commit has #1429 merged. |
Hallberg-NOAA
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
I agree with the logic of these changes, and they have passed both the TC testing and the pipeline tests (which I ran manually). In particular, the halo update on the input file mask should avoid improperly using data that inadvertently differs between PEs.
However, it should be noted that this PR could change answers in some (unidentified) cases that attempt to use the velocity sponges at open boundary points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to #1430, sitting on other PRs, hopefully not a problem.
@MJHarrison-GFDL's tips were helpful, not quite all that was required.
I cleaned up the unused tmpT1d stuff from the uv sponges.