Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitlab pipeline to use scripts from MOM6-examples #1436

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Conversation

adcroft
Copy link
Collaborator

@adcroft adcroft commented Jun 30, 2021

This essentially moves commands from .gitlab-ci.yaml to scripts in MOM6-examples.

  • This emphasizes the circular dependence we have for testing: MOM6-examples is the one place that "knows" versions and paths to src repositories and so is where we have to define the build process.
  • For now, I've put in place the same Makefiles we were using anyway but we will work towards a library-style approach allowing a mode modular definition of the build process
  • The .gitlab-ci.yml is much simpler (one line per test)
  • I took the opportunity to fold (tidy) much of the output to avoid defaulting to massive raw logs, e.g. https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/jobs/66390
  • I also sped up the end-to-end by about 5 minutes although we are subject to waiting in the queue and a slow lustre file system, and thus still ~1 hr.

adcroft and others added 2 commits June 30, 2021 11:20
- Reduce entries in .gitlab-ci.yml to mostly just one line by invoking scripts in MOM6-examples
  - This undoes early direction of moving detailed control into the pipeline yaml
- todo: define a library build process from within each child repository
Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the script simplification in these updates, and they are passing both the TC testing and the updated pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13051 .

@Hallberg-NOAA Hallberg-NOAA merged commit 52f906c into mom-ocean:dev/gfdl Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants