Added thkcello diagnostic #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrected calculation of thkcello, cell thickness in meters, for non-Boussinesq mode. - Moved diagnostic of thkcello into MOM_diagnostics.F90 from MOM.F90. - Renamed a temporary 3d array which is re-used by various diagnostics. - Closes issue #98.
|
Fixed a diagnostic bug related to thkcello. The field p_surf was incorrectly accessed for cases where this field was not allocated. The bug fix was applied in commit ad5aab0 |
|
the diagnostic appears to be fine now for both Bouss and non-Bouss. Will thus close the issue. |
|
not sure how to close the ticket...there is no "close and comment" button on my window... |
|
The pull request (ticket #150) was labelled "merged" by GitHub once you pushed the merge commit to dev/master. You can relax. |
Closed
alperaltuntas
pushed a commit
to gustavo-marques/MOM6
that referenced
this pull request
May 19, 2020
OpenMP and KPP performance changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@StephenGriffies , Since you spotted how I messed up the last attempt at this, you now have the role of reviewing this commit. I have not provided a branch on MOM6-examples but this commit will cause changes to the available_diags. We should also add thkcello to a diag_table in the usual places.
From commit 00ba2d7:
Added thkcello diagnostic
for non-Boussinesq mode.
MOM.F90.
diagnostics.