(+*)Fix MEKE advection bug #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the new runtime option MEKE_ADVECTION_BUG and corrected a bug in the calculation of the vertically integrated transport for the advection of the MEKE field when MEKE_ADVECTION_FACTOR > 0. The default is to fix the bug, so answers can change in some cases by default, and in those cases there are changes to the MOM_parameter_doc files, but this option is not widely used and there are no answer changes in the MOM6-examples test suite. This PR addresses MOM6 issue mom-ocean#1465, which can be closed once this PR is merged into dev/gfdl.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1506 +/- ##
============================================
- Coverage 29.06% 29.06% -0.01%
============================================
Files 237 237
Lines 71643 71649 +6
============================================
+ Hits 20823 20824 +1
- Misses 50820 50825 +5
Continue to review full report at Codecov.
|
marshallward
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new runtime option MEKE_ADVECTION_BUG and corrected a bug in the
calculation of the vertically integrated transport for the advection of the
MEKE field when MEKE_ADVECTION_FACTOR > 0. The default is to fix the bug, so
answers can change in some cases by default, and in those cases there are
changes to the MOM_parameter_doc files, but this option is not widely used and
there are no answer changes in the MOM6-examples test suite. This PR addresses
MOM6 issue #1465, which can be closed once this PR is merged into dev/gfdl.