Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix low mode in tidal_mixing #1515

Merged

Conversation

raphaeldussin
Copy link
Contributor

@raphaeldussin raphaeldussin commented Oct 11, 2021

this PR updates some function prototypes to pass the necessary structures for the get_lowmode function to work.
The teleport function is commented out since its behavior is inadequate and might not be necessary anymore.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #1515 (47b8948) into dev/gfdl (037af8e) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev/gfdl    #1515   +/-   ##
=========================================
  Coverage     29.08%   29.08%           
=========================================
  Files           239      239           
  Lines         71586    71582    -4     
=========================================
  Hits          20821    20821           
+ Misses        50765    50761    -4     
Impacted Files Coverage Δ
...c/parameterizations/lateral/MOM_internal_tides.F90 0.00% <ø> (ø)
...rc/parameterizations/vertical/MOM_tidal_mixing.F90 2.23% <33.33%> (ø)
...parameterizations/vertical/MOM_set_diffusivity.F90 32.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 037af8e...47b8948. Read the comment docs.

@marshallward
Copy link
Collaborator

Hi @raphaeldussin , given the increased PR traffic, would it be possible to move these draft PRs to another place, such as your own repo or the Discussions tab, until they are ready for review?

@marshallward
Copy link
Collaborator

After some discussion, I agree with @raphaeldussin that draft PRs fill a niche for discussing potential code changes and encouraging new contributions, and that it's far too premature to simply stop using them.

We might explore other options in the future (tags, Discussion tab, etc) but that can wait for now.

@raphaeldussin raphaeldussin marked this pull request as ready for review October 18, 2021 13:18
Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all seem reasonable, especially given that the internal tides ray tracing code is a (maturing) work-in progress. This PR should be accepted once it has passed the pipeline testing.

@marshallward
Copy link
Collaborator

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13888 ✔️

@marshallward marshallward merged commit ee3b92f into mom-ocean:dev/gfdl Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants