User/z1l/openmp #24
Merged
User/z1l/openmp #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavo-marques
pushed a commit
to gustavo-marques/MOM6
that referenced
this pull request
Aug 24, 2017
Fixes bugs in the ISOMIP test case
nikizadehgfdl
pushed a commit
to nikizadehgfdl/MOM6
that referenced
this pull request
Oct 9, 2017
- Updates MOM_parameter_doc files. - NOAA-GFDL/MOM6@2a928ee Merge branch 'user/ksh/bad_segs' into dev/master - NOAA-GFDL/MOM6@ec30811 Some index fixes. - NOAA-GFDL/MOM6@a083e65 Merge branch 'user/ksh/open_bc' into user/ksh/bad_segs - NOAA-GFDL/MOM6@cf87566 Merge pull request mom-ocean#24 from ESMG/user/mjh/open_bc - NOAA-GFDL/MOM6@0a007d0 new segment data names for normal and tangent vel add "ke" to OBC structure - NOAA-GFDL/MOM6@5147edc +Eliminated the calculate_2_densities routines - NOAA-GFDL/MOM6@d8c0d1d Fix supercritical GRADIENT condition. - NOAA-GFDL/MOM6@7d28845 Some updates, not compiling. - NOAA-GFDL/MOM6@e3dab80 Comment out call to initialize_segment_data. - NOAA-GFDL/MOM6@fbaa8d9 Adding dt factor to nudging (required). - NOAA-GFDL/MOM6@e791b48 Turn off OBC_update for Specified boundaries (for now). - NOAA-GFDL/MOM6@87d070c remove unnecessary check for symmetric compile in setup_segment_indices - NOAA-GFDL/MOM6@39f3b74 Undid changes to re-activate circle_obcs - NOAA-GFDL/MOM6@f8ecb1e Re-purposed OBC%HI for segment indexing - NOAA-GFDL/MOM6@5ca94c4 Added tangent velocity component to OB segment data type - NOAA-GFDL/MOM6@e4e92e6 Removed optional argument to extract_word() - NOAA-GFDL/MOM6@cb4a3dc initialize segments but dont use them
Hallberg-NOAA
added a commit
to Hallberg-NOAA/MOM6
that referenced
this pull request
Dec 7, 2021
Corrected the expressionfs for the por_face_areaU arguments being passed to zonal_face_thickness to avoid the array out-of-bounds index errors highlighted in MOM6 issue mom-ocean#24. Also added comments noting where the por_face_area arrays should probably be included in the effective (relative) face thickness calculations that are later used for finding the vertically averaged accelerations by the barotropic solver. All answers and output are bitwise identical in cases that work, but this should avoid some run-time or compile-time errors with some compiler settings.
Hallberg-NOAA
added a commit
to marshallward/MOM6
that referenced
this pull request
Dec 11, 2021
Corrected the expressionfs for the por_face_areaU arguments being passed to zonal_face_thickness to avoid the array out-of-bounds index errors highlighted in MOM6 issue mom-ocean#24. Also added comments noting where the por_face_area arrays should probably be included in the effective (relative) face thickness calculations that are later used for finding the vertically averaged accelerations by the barotropic solver. All answers and output are bitwise identical in cases that work, but this should avoid some run-time or compile-time errors with some compiler settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.