Specify the optional arguments passed to mpp_write_meta #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-The optional arguments to mpp_write_meta are not explicitly named (e.g.,foo(myunit) rather than foo(units=myunits)).
The problem with that is if someone adds a new argument of the same type to the mpp_write_meta (foo(newunits,units))
then the compiler gets confused and the result may be not what you want.
This senario has actually happened during testing for a FMS patch and caused crash.
-The solution is to always name the optional arguments being passed.