Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global/Volume Mean Functions + Diags #36

Closed
wants to merge 1 commit into from

Conversation

jkrasting
Copy link
Contributor

  • Added two functions: global_ij_mean and global_volume_mean
  • Rewrote SST_global and SSS_global to use these functions
  • Added temp_global and salt_global diagnostics

(NOTE: These are independent of and do not depend on any of the CMOR mods from yesterday's pull request)

- Added two functions: global_ij_mean and global_volume_mean
- Rewrote SST_global and SSS_global to use these functions
- Added temp_global and salt_global diagnostics
@adcroft
Copy link
Collaborator

adcroft commented Jul 18, 2014

Looks good. Can I suggest minor alteration; rename global_ij_mean to global_area_mean? I know Bob used global_i_mean but that is because it not the same as global_x_mean (tri-polar grid). In this case, it really is the correct global area mean. To me, a global_ij_mean would be a mean in i-j space (i.e. numerical and not physical.

@jkrasting
Copy link
Contributor Author

Fair point ... made the change, just doing a quick test. Will cancel this request, and make a new one. Will also include a diag_table this time.

@jkrasting jkrasting closed this Jul 18, 2014
@adcroft
Copy link
Collaborator

adcroft commented Jul 18, 2014

No need to cancel - I think you can just update it.

Too late!

Dr Alistair Adcroft (Alistair.Adcroft@noaa.gov)
Princeton University Tel: (609) 987-5073
NOAA/GFDL, 201 Forrestal Road, Princeton, NJ 08540

On Fri, Jul 18, 2014 at 11:26 AM, John Krasting notifications@github.com
wrote:

Closed #36 #36.


Reply to this email directly or view it on GitHub
#36 (comment).

gustavo-marques added a commit to gustavo-marques/MOM6 that referenced this pull request Dec 12, 2017
MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/MOM6 that referenced this pull request Jun 15, 2021
MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/MOM6 that referenced this pull request Jun 15, 2021
MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/MOM6 that referenced this pull request Jun 15, 2021
MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/MOM6 that referenced this pull request Jun 15, 2021
marshallward pushed a commit to Hallberg-NOAA/MOM6 that referenced this pull request Dec 18, 2021
* Adding temperature restore capability for SPEAR.

Added parameter SPEAR_ECDA_SST_RESTORE_TFREEZE to allow activation of
sea surface salinity based modification of restoring of temperature.
The formula used is different from the Millero (default in SPEAR runs)
scheme.

* removed spaces on blank line.

* (*)Changed hard wired value to parameter defined in MOM_override

The freezing temperature came from SIS2 code. Changing the default value here to be consistent with that. (-0.054 vs -0.0539)
The salinity restoring code used the -0.0539 value also so answers may change if using that code (RESTORE_SALINITY=T)

* (*)Changed hard wired value to parameter defined in MOM_override

The freezing temperature came from SIS2 code. Changing the default value here to be consistent with that. (-0.054 vs -0.0539)
The salinity restoring code used the -0.0539 value also so answers may change if using that code (RESTORE_SALINITY=T)

* Forgot to replace the salinity masking mulitplier with the override
parameter
MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/MOM6 that referenced this pull request Aug 16, 2022
…m_rwh

Added coupler_type_extract_data and coupler_type_set_data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants