Added modified Leith viscosity. #515
Conversation
Added a term proportional to the gradient of divergence to the Leith viscosity, which turns regular 2D Leith into Modified Leith.
|
@Hallberg-NOAA FYI, this passes our tests. Just needs you code review. https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/1938 |
|
In the land of Mordor, in the fires of Mount Doom, the Dark Lord
Bachman forged in secret, a master closure, to control all others. And into
this closure he poured his cruelty, his malice, and his will to dominate
all ocean modeling.
…On Tue, Jun 13, 2017 at 11:24 AM, Alistair Adcroft ***@***.*** > wrote:
@Hallberg-NOAA <https://github.com/hallberg-noaa> FYI, this passes our
tests. Just needs you code review. https://gitlab.gfdl.noaa.gov/
ogrp/MOM6/pipelines/1938
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<NOAA-GFDL#515 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATrzIr3jdyouRmFScomoybOTIGzcj0rRks5sDsXKgaJpZM4N1wyO>
.
|
|
|
|
Overall this looks great, but there are two things that need to be fixed here before it should be merged. |
There was a problem hiding this comment.
This appears to be a nice addition, but CS%Modified_Leith is currently not initialized. There needs to be a get_param call for this new parameter (or at least it needs to be set to something) before this code should be merged onto the main branch. Without this, there may be capricious or compiler-dependent behavior.
Initialized variable CS%Modified_Leith and added a get_param call for it.
|
It's in the pipe... https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/2007
…--
Dr Alistair Adcroft (Alistair.Adcroft@noaa.gov)
Princeton University Tel: (609) 987-5073
NOAA/GFDL, 201 Forrestal Road, Princeton, NJ 08540
On Fri, Jun 23, 2017 at 11:04 AM, Robert Hallberg ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<NOAA-GFDL#515 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFlo85-OlY4R6PPgFfHI8bTNmk5-GCsHks5sG9PjgaJpZM4N1wyO>
.
|
Added a term proportional to the gradient of divergence to the
Leith viscosity, which turns regular 2D Leith into Modified Leith.