Added a clock argument to halo update calls #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added optional arguments to use a CPU time clocks to all of the message passing calls in MOM_domains.F90. Also dOxygenized most of the subroutine and function calls in MOM_domains. All answers are bitwise identical.
Simplified the code in many placed by using the new clock optional argument to a halo update call in place of three calls to start the clock, do the update, and then stop the clock. All answers are bitwise identical.
nikizadehgfdl
pushed a commit
to nikizadehgfdl/MOM6
that referenced
this pull request
Oct 9, 2017
- Updates available_diags - Merge NOAA-GFDL/MOM6@a4cc554 closes mom-ocean#162 - Merge NOAA-GFDL/MOM6@950718f updates mom-ocean#165 and mom-ocean#154 - NOAA-GFDL/MOM6@a2101cf Merge branch 'adcroft-fix_uhml_units' into dev/gfdl - NOAA-GFDL/MOM6@11ad230 Add units for uhml,vhml - NOAA-GFDL/MOM6@fc732ac Merge pull request mom-ocean#604 from breichl/user/bgr/EPBL_OSBL_DIAG - NOAA-GFDL/MOM6@c4ebae8 Merge pull request mom-ocean#606 from adcroft/diag_rfcn1 - NOAA-GFDL/MOM6@2350dba Merge pull request mom-ocean#605 from NOAA-GFDL/halo_update_clock - NOAA-GFDL/MOM6@8dada7e Fixes allocation issue for diagnostics in rho coords - NOAA-GFDL/MOM6@4ac331c Merge pull request mom-ocean#603 from ashao/remapped_boundary_flux_tendencies - NOAA-GFDL/MOM6@a204620 Use clock argument in halo update calls - NOAA-GFDL/MOM6@9be672e Add cmor description to ePBL_h_ML diagnostic - NOAA-GFDL/MOM6@4cfab37 +Added optional clock arg to halo update routines - NOAA-GFDL/MOM6@950718f Merge pull request mom-ocean#601 from adcroft/fix_units_vhml_vhgm - NOAA-GFDL/MOM6@78724e3 Merge pull request mom-ocean#600 from nikizadehgfdl/user/nnz/fix_OMP_issue_similar_588 - NOAA-GFDL/MOM6@a8f0b99 Change units of parameterized transport to kg s-1 - NOAA-GFDL/MOM6@a4cc554 Merge pull request mom-ocean#597 from ashao/update_grid_after_boundaryfluxes - NOAA-GFDL/MOM6@f9f97de Merge pull request mom-ocean#598 from NOAA-GFDL/input_filename_F - NOAA-GFDL/MOM6@baa8039 Merge pull request mom-ocean#599 from adcroft/diag_rfcn1 - NOAA-GFDL/MOM6@2987394 Progress towards conservative boundary flux tendencies - NOAA-GFDL/MOM6@eaa407a Fix OMP issue similar to 588 - NOAA-GFDL/MOM6@5cf60bf Generate profile for diagnostic density coordinate - NOAA-GFDL/MOM6@9006d33 Removed trailing white space - NOAA-GFDL/MOM6@3f10926 +Added 'F' input_filename option - NOAA-GFDL/MOM6@a972015 Fix for nonzero remapped vertical diffusion tendencies - NOAA-GFDL/MOM6@c4f6b72 Reordered diagnostic calls at end of step_MOM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help with code clean-up by allowing a CPU clock to specified with any of the halo update calls. In the many cases where this is being used three calls from the high-level routines are being replaced by a single call, and the code has become easier to read.