+Top-level arguments control MOM6 time stepping #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new overloaded variants of safe_alloc_ptr and safe_alloc_alloc to allow the index range of the third (vertical) index to have an arbitrary starting value. All answers are bitwise identical.
Added error messages and Adcroft reciprocals to trap or handle cases when dt=0 in various routines in MOM_diabatic_driver including diabatic and legacy_diabatic. All answers are bitwise identical.
Allow optional arguments to step_MOM to effectively override the value of DIABATIC_FIRST. All answers are bitwise identical in the existing test cases.
|
This PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/7131 |
Store the thermodynamic clock at the start of update_ocean_model so that it does not get incorrectly updated during purely dynamic steps. When both dynamics and thermodynamics are stepped together, nothing is changed, but when they are stepped separately, this correct the thermodynamic clock that is used primarily for diagnostics. All answers are bitwise identical in the existing test cases.
|
This updated PR is being tested with https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/7272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the top-level optional control arguments to specify the timestepping of
MOM6, including ignoring the DIABATIC_FIRST flag when there are separate calls
to step the dynamics and thermodynamics. No answers or parameter_doc files are
changed in any existing test cases. The list of commits in this PR include: