Skip to content

Commit

Permalink
Revert: moved moment to peerDependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
ellenaua committed Jun 18, 2018
1 parent 4c5f26b commit 3a9a2df
Show file tree
Hide file tree
Showing 10 changed files with 17 additions and 15 deletions.
4 changes: 2 additions & 2 deletions builds/moment-timezone-with-data-2012-2022.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! moment-timezone.js
//! version : 0.5.18
//! version : 0.5.19
//! Copyright (c) JS Foundation and other contributors
//! license : MIT
//! github.com/moment/moment-timezone
Expand All @@ -23,7 +23,7 @@
// return moment;
// }

var VERSION = "0.5.18",
var VERSION = "0.5.19",
zones = {},
links = {},
names = {},
Expand Down
2 changes: 1 addition & 1 deletion builds/moment-timezone-with-data-2012-2022.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions builds/moment-timezone-with-data.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion builds/moment-timezone-with-data.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion builds/moment-timezone.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### `0.5.19` _2018-06-18_
* Revert: moved moment to peerDependencies #628

### `0.5.18` _2018-06-18_
* Return error when timezone name is not a string. #616
* Moved moment to peerDependencies #628
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "moment/moment-timezone",
"description": "Parse and display dates in any timezone",
"version": "0.5.18",
"version": "0.5.19",
"keywords": [
"moment",
"date",
Expand Down
2 changes: 1 addition & 1 deletion moment-timezone-utils.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! moment-timezone-utils.js
//! version : 0.5.18
//! version : 0.5.19
//! Copyright (c) JS Foundation and other contributors
//! license : MIT
//! github.com/moment/moment-timezone
Expand Down
4 changes: 2 additions & 2 deletions moment-timezone.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//! moment-timezone.js
//! version : 0.5.18
//! version : 0.5.19
//! Copyright (c) JS Foundation and other contributors
//! license : MIT
//! github.com/moment/moment-timezone
Expand All @@ -23,7 +23,7 @@
// return moment;
// }

var VERSION = "0.5.18",
var VERSION = "0.5.19",
zones = {},
links = {},
names = {},
Expand Down
7 changes: 3 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "moment-timezone",
"version": "0.5.18",
"version": "0.5.19",
"description": "Parse and display moments in any timezone.",
"homepage": "http://momentjs.com/timezone/",
"author": "Tim Wood <washwithcare@gmail.com> (http://timwoodcreates.com/)",
Expand All @@ -26,16 +26,15 @@
"url": "https://github.com/moment/moment-timezone/issues"
},
"license": "MIT",
"peerDependencies": {
"dependencies": {
"moment": ">= 2.9.0"
},
"devDependencies": {
"grunt": "1.0.2",
"grunt-contrib-clean": "^1.1.0",
"grunt-contrib-jshint": "^1.1.0",
"grunt-contrib-nodeunit": "^1.0.0",
"grunt-contrib-uglify": "^3.1.0",
"moment": ">= 2.9.0"
"grunt-contrib-uglify": "^3.1.0"
},
"jspm": {
"main": "builds/moment-timezone-with-data",
Expand Down

3 comments on commit 3a9a2df

@rpellerin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why revert this?

@ashein
Copy link

@ashein ashein commented on 3a9a2df Mar 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering why it's still not a peer dependency in 2019. Well, at least there's still 0.5.18 one can pin to make the package link to Moment properly..

@Americas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran into a problem because of moment being declared as a dependency rather than a peer dependency.

moment-timezone installed it's own version of moment different from the package defined one, and suddenly timezone is not installed in the moment object.

🤦‍♂️

Please sign in to comment.