Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Add 'ss' relative time key to typescript definition #4246

Merged
merged 4 commits into from
Dec 11, 2017

Conversation

xkxx
Copy link
Contributor

@xkxx xkxx commented Oct 17, 2017

Hi there,

This patch adds 'ss' to RelativeTimeKey to make the typescript definition more complete, and updates the typing tests to match.

First patch to moment.js, so please let me know if there's anything I'm missing or if you have any suggestions for improvements!

@ichernev
Copy link
Contributor

This is the same as #4138 but slightly better, maybe :)

@xkxx
Copy link
Contributor Author

xkxx commented Oct 25, 2017

Hi ichernev!

Is there anything that I need to address in the PR for it to be accepted?

Thanks,

xkxx

@ichernev
Copy link
Contributor

@jsf-clabot
Copy link

jsf-clabot commented Oct 26, 2017

CLA assistant check
All committers have signed the CLA.

@xkxx
Copy link
Contributor Author

xkxx commented Oct 27, 2017

Hi @ichernev,

How's the PR looking now? (Please ignore the git author screwup earlier :/)

@xkxx
Copy link
Contributor Author

xkxx commented Nov 6, 2017

Hello @ichernev again,

Could you take a look at this PR and see if there's anything else for it to be merged?

Thanks,

xkxx

@xkxx
Copy link
Contributor Author

xkxx commented Nov 14, 2017

Hello, just a friendly ping if anyone would like to take another look at the PR :)

@butterflyhug
Copy link
Contributor

I think this looks good -- tagging for inclusion in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants