-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] Add 'ss' relative time key to typescript definition #4246
Conversation
This is the same as #4138 but slightly better, maybe :) |
Hi ichernev! Is there anything that I need to address in the PR for it to be accepted? Thanks, xkxx |
Hi @ichernev, How's the PR looking now? (Please ignore the git author screwup earlier :/) |
Hello @ichernev again, Could you take a look at this PR and see if there's anything else for it to be merged? Thanks, xkxx |
Hello, just a friendly ping if anyone would like to take another look at the PR :) |
I think this looks good -- tagging for inclusion in the next release. |
Hi there,
This patch adds 'ss' to RelativeTimeKey to make the typescript definition more complete, and updates the typing tests to match.
First patch to moment.js, so please let me know if there's anything I'm missing or if you have any suggestions for improvements!