Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#CX-12280 : Adding Editable div to behave like input element #1483

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

prakhar-tiwari
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (ddf1ee3) 94.39% compared to head (f6b0afd) 93.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
- Coverage   94.39%   93.97%   -0.42%     
==========================================
  Files         134      134              
  Lines       18922    18970      +48     
  Branches     2890     2892       +2     
==========================================
- Hits        17861    17827      -34     
- Misses       1061     1143      +82     
Files Coverage Δ
web-components/src/components/input/Input.ts 92.61% <22.00%> (-6.27%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant