Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Slido 16x16 icon #1501

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VaibhavDesai
Copy link

@VaibhavDesai VaibhavDesai commented Nov 1, 2023

Adding this icon to the momentum library so that it can be used to display Slido Analytics on the CH Analytics page

Description

Here is a screenshot of the where the icon will be used.
Screenshot 2023-11-01 at 12 30 58 PM

The UX lead on this is Mina Yoo (miyoo@cisco.com)

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (953f71e) 94.17% compared to head (b054798) 93.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
- Coverage   94.17%   93.99%   -0.18%     
==========================================
  Files         134      134              
  Lines       18974    18974              
  Branches     2902     2899       -3     
==========================================
- Hits        17868    17834      -34     
- Misses       1106     1140      +34     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant