Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar icon updates #1757

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Avatar icon updates #1757

merged 3 commits into from
Aug 26, 2024

Conversation

NotNestor
Copy link
Collaborator

Description

  • Allow newMomentum to display bot badge
  • Update momentumV2 icon avatar background colour
  • update presence icon to always return a size so inbetween sizes still have an icon
  • update inactive avatar background to not have opacity set

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@NotNestor NotNestor requested a review from AlanSpillane August 26, 2024 13:26
@NotNestor NotNestor merged commit 554d190 into momentum-design:master Aug 26, 2024
8 checks passed
@NotNestor NotNestor deleted the AvatarIconUpdates branch August 26, 2024 13:37
nithishkumar98 pushed a commit that referenced this pull request Aug 29, 2024
@NotNestor @jnestorCisco @nithishkumar98
Avatar icon updates (#1757)
5f4a1ef 
* chore: update icon avatar

* chore: update getPresenceSize so a value is always returned

* chore: update package version

---------

Co-authored-by: James Nestor <jnestor@cisco.com>
parsoman pushed a commit to parsoman/momentum-ui that referenced this pull request Aug 29, 2024
@NotNestor @jnestorCisco @parsoman
Avatar icon updates (momentum-design#1757)
6796a74 
* chore: update icon avatar

* chore: update getPresenceSize so a value is always returned

* chore: update package version

---------

Co-authored-by: James Nestor <jnestor@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanSpillane AlanSpillane AlanSpillane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotNestor @AlanSpillane @jnestorCisco