Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Contact" UI not clear (3.1; build 285) #130

Closed
Tracked by #322
ge0rg opened this issue Nov 11, 2018 · 8 comments
Closed
Tracked by #322

"Add Contact" UI not clear (3.1; build 285) #130

ge0rg opened this issue Nov 11, 2018 · 8 comments
Labels
🎨 UI Related to visual appreance of the app (User Interface)

Comments

@ge0rg
Copy link

ge0rg commented Nov 11, 2018

The "Add Contact" dialog has a single input box "Contact Name" with a hint regarding the format of a JID.

However, "Contact Name" implies that this is the place to enter the screen name, not the JID of the contact, and there is no way to edit the actual screen name.

After tapping "Add contact", a modal dialog is shown, which is rather bad practice, and you return to the "Add Contact" screen instead of the roster.

@Echolon
Copy link
Contributor

Echolon commented Nov 11, 2018

I think you need to be more precise or drop a screenshot

@ge0rg
Copy link
Author

ge0rg commented Nov 11, 2018

The "Add contact" dialog:

The modal popup:

And after pressing "Close" I'm back at "Add contact".

@ge0rg ge0rg changed the title "Add Contact" UI not clear "Add Contact" UI not clear (3.1; build 285) Nov 11, 2018
@Echolon
Copy link
Contributor

Echolon commented Nov 11, 2018

@ge0rg Okay, now I get what you mean and I think you are absolutely right. This needs an overwork.

I suggest to first say "Contact has been added sucessfully" (or even better, just switch to the contact menu or conversations and show the added contact). Second, somehow show a message in the chat that Monal is awaiting the permission.

@anurodhp
Copy link
Contributor

Good idea on the dismissal. The modal is there because I found even when I used it that there wasn't an obvious indicator of success. Im open on changing the language. What is there is literally the first thing I thought. Do people know what JIds mean? Contact address maybe?

At the moment I am leaning towards:
Contact Added Successfully

The new person will be added to your contacts list when they have approved your request.

@ge0rg
Copy link
Author

ge0rg commented Nov 13, 2018

From my experience, the best thing would be to display the Chat tab for the new contact right after requesting permission, and maybe to have an indication of the subscription status / presence that would be updated on approval.

@anurodhp
Copy link
Contributor

anurodhp commented Nov 13, 2018 via email

@Echolon
Copy link
Contributor

Echolon commented Dec 19, 2018

I would additionally suggest, to build an inline add button. so that users can directly add a contact from chat window. the same goes for MUCs. it should be clear what's a single person or whats a group chat before adding/joining

@Echolon Echolon mentioned this issue Jan 4, 2020
65 tasks
@Echolon Echolon added the 🎨 UI Related to visual appreance of the app (User Interface) label Jan 4, 2020
@anurodhp
Copy link
Contributor

There is an add contact button in contact details screen for adding contacts itself takes you to the chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 UI Related to visual appreance of the app (User Interface)
Projects
None yet
Development

No branches or pull requests

3 participants