feat: berglas: use update and CreateIfMissing strategy for Set

mondoohq · Jul 22, 2024 · 3ba3e4a · 3ba3e4a
1 parent c15ad5c
commit 3ba3e4a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/providers-sdk/v1/vault/gcpberglas/berglas.go b/providers-sdk/v1/vault/gcpberglas/berglas.go
@@ -139,11 +139,12 @@ func (v *Vault) Set(ctx context.Context, cred *vault.Secret) (*vault.SecretID, e
 		return nil, err
 	}
 
-	_, err = c.Create(ctx, &berglas.StorageCreateRequest{
-		Bucket:    v.bucket,
-		Object:    cred.Key,
-		Plaintext: cred.Data,
-		Key:       v.kmsKeyID,
+	_, err = c.Update(ctx, &berglas.StorageUpdateRequest{
+		Bucket:          v.bucket,
+		Object:          cred.Key,
+		Plaintext:       cred.Data,
+		Key:             v.kmsKeyID,
+		CreateIfMissing: true,
 	})
 	if err != nil {
 		return nil, err

diff --git a/providers-sdk/v1/vault/gcpberglas/berglas_test.go b/providers-sdk/v1/vault/gcpberglas/berglas_test.go
@@ -32,4 +32,11 @@ func TestGcpBerglas(t *testing.T) {
 	get, err := v.Get(ctx, &vault.SecretID{Key: cred.Key})
 	require.NoError(t, err)
 	assert.Equal(t, cred.Data, get.Data)
+
+	cred.Data = []byte("my-even-more-secret-data")
+	_, err = v.Set(ctx, cred)
+	require.NoError(t, err)
+	get, err = v.Get(ctx, &vault.SecretID{Key: cred.Key})
+	require.NoError(t, err)
+	assert.Equal(t, cred.Data, get.Data)
 }