Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Fetch registry packages for Windows filesystem connections #4205

Merged
merged 1 commit into from
Jun 7, 2024
Merged

✨ Fetch registry packages for Windows filesystem connections #4205

merged 1 commit into from
Jun 7, 2024

Conversation

preslavgerchev
Copy link
Contributor

After #4204

PS C:\Users\mondoo> ./cnquery run fs --path F:\ -c 'packages'
Flag --path has been deprecated, has been deprecated
Flag --path has been deprecated, has been deprecated
WRN using builtin provider for os
WRN no path provided as an arg, looking for --path flag
WRN using builtin provider for os
- no Mondoo configuration file provided, using defaults
WRN using builtin provider for os
packages.list: [
  0: package name="Microsoft Edge" version="124.0.2478.97"
]

preslavgerchev
preslavgerchev commented Jun 6, 2024
View reviewed changes
providers/os/resources/packages/windows_packages.go Outdated
}
for _, c := range children {
// for each package the information is contained as children of that registry's key
p := w.getPackageFromRegistryKey(c)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the same logic as the localInstalledApps, only difference is we let the registry handler tell us where the keys are mounted via GetNativeRegistryKeyChildren

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited
Loading

Test Results

3 058 tests  ±0   3 057 ✅ ±0   1m 28s ⏱️ -1s
  355 suites ±0       1 💤 ±0 
   26 files   ±0       0 ❌ ±0 

Results for commit 6dbe256. ± Comparison against base commit f63ece7.

♻️ This comment has been updated with latest results.

afiune
afiune approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@preslavgerchev preslavgerchev force-pushed the preslav/use-reg-keys branch from 3d67cc2 to a0b72fb Compare June 7, 2024 05:53
Base automatically changed from preslav/use-reg-keys to main June 7, 2024 06:16
@preslavgerchev
✨ Fetch registry packages for Windows filesystem connections
6dbe256 
Signed-off-by: Preslav <preslav@mondoo.com>
@preslavgerchev preslavgerchev force-pushed the preslav/use-reg-keys-v2 branch from 3ed8309 to 6dbe256 Compare June 7, 2024 06:26
@preslavgerchev preslavgerchev merged commit 9c024b3 into main Jun 7, 2024
15 checks passed
@preslavgerchev preslavgerchev deleted the preslav/use-reg-keys-v2 branch June 7, 2024 06:31
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afiune afiune afiune approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preslavgerchev @afiune