-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 add k8s services to discovery #4211
Conversation
vjeffrey
commented
Jun 10, 2024
•
edited
Loading
edited
![Screenshot 2024-06-10 at 16 16 52](https://private-user-images.githubusercontent.com/10341541/338366311-71c5fde7-8ac1-48e7-94da-6f47849df7d4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NDkxODYsIm5iZiI6MTczOTQ0ODg4NiwicGF0aCI6Ii8xMDM0MTU0MS8zMzgzNjYzMTEtNzFjNWZkZTctOGFjMS00OGU3LTk0ZGEtNmY0Nzg0OWRmN2Q0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDEyMTQ0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc2ZjIyMjU5NDM3NmZmOTMzOTY5OGFlNTRiZTc5NmZhMGFhYWZkZDQ1ZmJjZmEzMTQxOTI3ZGZiODZlOTI4ZDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._8B8dp0t1S3pY2cGBDzEDG7wgkOeY_zIEsJ4guNPGps)
a0756a1
to
9ba8213
Compare
providers/k8s/resources/discovery.go
Outdated
@@ -933,6 +996,10 @@ func createPlatformData(objectKind, runtime string) (*inventory.Platform, error) | |||
platformData.Family = append(platformData.Family, "k8s-workload") | |||
platformData.Name = "k8s-cronjob" | |||
platformData.Title = "Kubernetes CronJob" | |||
case "Service": | |||
platformData.Family = append(platformData.Family, "k8s-workload") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A service
is not really a workload. Perhaps we need a new family for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imilchev Any ideas? Or should we go with k8s-service
as its own family, like in k8s-ingress
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right, this should be k8s-service
Gave this a try. LGTM:
|
Signed-off-by: Ivan Milchev <ivan@mondoo.com>
9ba8213
to
cc2b26f
Compare