handle GitHub API rate limits
#4298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czunker
reviewed
Jun 28, 2024
| if resp.Header.Get("x-ratelimit-remaining") == "0" { | ||
| unix, err := strconv.ParseInt(resp.Header.Get("x-ratelimit-reset"), 10, 64) // x-ratelimit-reset - The time at which the current rate limit window resets, in UTC epoch seconds | ||
| if err != nil { // Must be impossible to hit errors here, but just in case | ||
| return time.Second * 8 // Github starts with 8s jailtime |
There was a problem hiding this comment.
Where did you find this? I only found a one minute pause on the secondary limit.
Do we need to handle primary and secondary separately?
There was a problem hiding this comment.
Couldn't find at this point.
What would you suggest for error handling?
I don't think so, no, it'll be reflected in wait time. But, I think we could add the maximum wait time and throw error after that, because otherwise the scan can be stuck up to an hour and provide no data
There was a problem hiding this comment.
Ok, I understood your comment in a way that it is some default GitHub setting.
I like the idea with the max wait time.
czunker
approved these changes
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on: https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#exceeding-the-rate-limit