Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐🌙 Cloudflare Provider #4743

Merged
merged 23 commits into from
Dec 2, 2024
Merged

⭐🌙 Cloudflare Provider #4743

merged 23 commits into from
Dec 2, 2024

Conversation

slntopp
Copy link
Member

@slntopp slntopp commented Oct 12, 2024

Includes:

  • Accounts
  • Zones
  • DNS Records
  • R2 (Cloudflare version of S3)
  • Zero Trust Networks
  • Zero Trust Apps
  • Argo Tunnels
  • Streams
  • Videos
  • Workers
  • Pages

@slntopp slntopp force-pushed the mik/cloudflare-provider branch 2 times, most recently from 0ecad60 to d8e1dfd Compare October 12, 2024 16:19
@chris-rock
Copy link
Member

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 12, 2024

Test Results

3 162 tests  ±0   3 161 ✅ ±0   1m 25s ⏱️ -7s
  372 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 98a602a. ± Comparison against base commit 21edd9f.

♻️ This comment has been updated with latest results.

This comment has been minimized.

@tas50
Copy link
Member

tas50 commented Oct 18, 2024

Ping @misterpantz for the lr file words

This comment has been minimized.

Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

halfway done with my review

providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

@slntopp
Copy link
Member Author

slntopp commented Oct 18, 2024

Thank you @misterpantz

This comment has been minimized.

@slntopp slntopp self-assigned this Oct 18, 2024
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved
providers/cloudflare/resources/cloudflare.lr Outdated Show resolved Hide resolved

This comment has been minimized.

@slntopp slntopp marked this pull request as ready for review November 8, 2024 16:04

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@slntopp slntopp requested a review from tas50 November 8, 2024 16:53
Copy link
Member

@imilchev imilchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added last 2 minor comments and then I think we can merge this

providers/cloudflare/config/config.go Show resolved Hide resolved
providers/cloudflare/connection/connection.go Outdated Show resolved Hide resolved
@slntopp slntopp merged commit 4e7c367 into main Dec 2, 2024
16 checks passed
@slntopp slntopp deleted the mik/cloudflare-provider branch December 2, 2024 12:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants