✨ Support searching /dev/disk/by-id aliases. #4795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results3 129 tests 3 128 ✅ 1m 22s ⏱️ Results for commit b0a6ad0. ♻️ This comment has been updated with latest results. |
|
I think it would've made more sense to just search in multiple paths instead of copying the method, since the logic is the same
|
imilchev
approved these changes
Nov 1, 2024
preslavgerchev
force-pushed
the
preslav/fix-gcp-snapshot
branch
from
53c0695 to
5a74832
Compare
Signed-off-by: Preslav <preslav@mondoo.com>
preslavgerchev
force-pushed
the
preslav/fix-gcp-snapshot
branch
from
5a74832 to
b0a6ad0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the GCP snapshot scanning. In GCP devices are aliased under
/dev/disk-by-id/<device-name>. This PR builds on top of the already supported alias finding by looking into that directory as well