Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 handle malformed array argument #4812

Merged
merged 1 commit into from
Nov 5, 2024
Merged

🐛 handle malformed array argument #4812

merged 1 commit into from
Nov 5, 2024

Conversation

slntopp
Copy link
Member

@slntopp slntopp commented Nov 4, 2024 •
edited
Loading

MQL to reproduce panic with unpatched versions:

"foo".in("bar baz".split(" ").map( [""][1] ))

Note

It appears that the usage of .map() allows to bypass the type assertion for .in()

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Test Results

3 131 tests  ±0   3 130 ✅ ±0   1m 30s ⏱️ +8s
  371 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 5bb3754. ± Comparison against base commit d69318b.

@slntopp slntopp mentioned this pull request Nov 4, 2024
Closed
@imilchev imilchev merged commit ea137ed into main Nov 5, 2024
15 checks passed
@imilchev imilchev deleted the mik/fix-in-operator-type-assertion branch November 5, 2024 07:39
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imilchev imilchev imilchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slntopp @imilchev