Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix the wrong iterator in user registration details. #4817

Merged
merged 1 commit into from
Nov 5, 2024
Merged

🐛 Fix the wrong iterator in user registration details. #4817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions providers/ms365/resources/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (

betamodels "github.com/microsoftgraph/msgraph-beta-sdk-go/models"
"github.com/microsoftgraph/msgraph-beta-sdk-go/reports"
betausers "github.com/microsoftgraph/msgraph-beta-sdk-go/users"
"github.com/microsoftgraph/msgraph-sdk-go/models"
"github.com/microsoftgraph/msgraph-sdk-go/users"
"go.mondoo.com/cnquery/v11/llx"
Expand Down Expand Up @@ -70,7 +69,7 @@ func (a *mqlMicrosoft) users() ([]interface{}, error) {
if err != nil {
a.mfaResp = mfaResp{err: err}
} else {
userRegistrationDetails, err := iterate[*betamodels.UserRegistrationDetails](ctx, detailsResp, betaClient.GetAdapter(), betausers.CreateDeltaGetResponseFromDiscriminatorValue)
userRegistrationDetails, err := iterate[*betamodels.UserRegistrationDetails](ctx, detailsResp, betaClient.GetAdapter(), betamodels.CreateUserRegistrationDetailsCollectionResponseFromDiscriminatorValue)
// we do not want to fail the user fetching here, this likely means the tenant does not have the right license
if err != nil {
a.mfaResp = mfaResp{err: err}
Expand Down
Loading