Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add aliases to partitions info #4859

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

slntopp
Copy link
Member

@slntopp slntopp commented Nov 14, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Test Results

3 145 tests  ±0   3 144 ✅ ±0   1m 27s ⏱️ +2s
  371 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 8fef42d. ± Comparison against base commit 0d5431c.

♻️ This comment has been updated with latest results.

@@ -11,6 +11,7 @@ type PartitionInfo struct {
Name string
FsType string

Aliases []string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you write a comment above on what those aliases are?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated them all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@slntopp slntopp merged commit 7ad82eb into main Nov 14, 2024
16 checks passed
@slntopp slntopp deleted the mik/device/add-aliases-to-partition-info branch November 14, 2024 12:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants