Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 use CIM instead of WMI for smbios #4899

Merged
merged 2 commits into from
Nov 20, 2024
Merged

🧹 use CIM instead of WMI for smbios #4899

merged 2 commits into from
Nov 20, 2024

Conversation

imilchev
Copy link
Member

@imilchev imilchev commented Nov 20, 2024

WMI is deprecated and can be slow, we migrate to its successor

I compared the results for machine.bios, machine.chassis, machine.baseboard, machine.system and they seem to return the same info

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
Copy link
Contributor

Test Results

3 003 tests   - 143   3 000 ✅  - 145   1m 23s ⏱️ -4s
  204 suites  - 167       1 💤 ±  0 
    4 files    -  24       2 ❌ +  2 

For more details on these failures, see this check.

Results for commit 8983946. ± Comparison against base commit d46d864.

This pull request removes 143 tests.
go.mondoo.com/cnquery/v11/providers/ansible/play ‑ TestPlaybookDecoding
go.mondoo.com/cnquery/v11/providers/ansible/play ‑ TestPlaybookDecoding/load_default_playbook
go.mondoo.com/cnquery/v11/providers/ansible/play ‑ TestPlaybookDecoding/load_playbook_with_blocks_and_errors
go.mondoo.com/cnquery/v11/providers/ansible/play ‑ TestPlaybookDecoding/load_playbook_with_multiple_plays
go.mondoo.com/cnquery/v11/providers/ansible/play ‑ TestPlaybookDecoding/load_playbook_with_roles
go.mondoo.com/cnquery/v11/providers/ansible/play ‑ TestPlaybookDecoding/load_playbook_with_serial
go.mondoo.com/cnquery/v11/providers/ansible/play ‑ TestPlaybookDecoding/load_playbook_with_vars
go.mondoo.com/cnquery/v11/providers/ansible/play ‑ TestTaskDecoding
go.mondoo.com/cnquery/v11/providers/ansible/play ‑ TestTaskDecoding/load_task_with_blocks
go.mondoo.com/cnquery/v11/providers/ansible/play ‑ TestTaskDecoding/load_task_with_vars
…

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @imilchev

@chris-rock chris-rock merged commit ecd846b into main Nov 20, 2024
7 checks passed
@chris-rock chris-rock deleted the ivan/wmi-cim branch November 20, 2024 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants