Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 AWS: Deprecate createdTime in favor of createdAt #4937

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🧹 AWS: Deprecate createdTime in favor of createdAt #4937

wants to merge 2 commits into from
+109 −6

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Nov 30, 2024

We use createdAt in 35 places and createTime in 6. Add createdAt to these resources and deprecate the existing createTime.

@tas50
AWS: Deprecated createdTime in favor of createdAt
d014e69 
We use createdAt in 35 places and createTime in 6. Add createdAt to
these resources and deprecate the existing createTime.

Signed-off-by: Tim Smith <tsmith84@gmail.com>
@tas50 tas50 changed the title AWS: Deprecated createdTime in favor of createdAt AWS: Deprecate createdTime in favor of createdAt Nov 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Test Results

3 162 tests  ±0   3 161 ✅ ±0   1m 41s ⏱️ +4s
  372 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit d014e69. ± Comparison against base commit cef7bda.

@tas50 tas50 changed the title AWS: Deprecate createdTime in favor of createdAt 🧹 AWS: Deprecate createdTime in favor of createdAt Dec 1, 2024
@misterpantz
Copy link
Contributor

I just made suggestions that'd make them consistent.

@tas50 @misterpantz
Apply suggestions from code review
c22b9d6 
Co-authored-by: Letha <letha@mondoo.com>
@tas50 tas50 requested a review from chris-rock December 2, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterpantz misterpantz misterpantz approved these changes

@chris-rock chris-rock Awaiting requested review from chris-rock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tas50 @misterpantz