Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 AWS: Deprecate createdTime in favor of createdAt #4937

Merged
merged 2 commits into from
Dec 16, 2024
Merged

🧹 AWS: Deprecate createdTime in favor of createdAt #4937

merged 2 commits into from
Dec 16, 2024

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Nov 30, 2024

We use createdAt in 35 places and createTime in 6. Add createdAt to these resources and deprecate the existing createTime.

@tas50 tas50 changed the title AWS: Deprecated createdTime in favor of createdAt AWS: Deprecate createdTime in favor of createdAt Nov 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 30, 2024 •
edited
Loading

Test Results

3 162 tests  ±0   3 161 ✅ ±0   1m 27s ⏱️ -3s
  372 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 4d272a1. ± Comparison against base commit 8fafbd8.

♻️ This comment has been updated with latest results.

@tas50 tas50 changed the title AWS: Deprecate createdTime in favor of createdAt 🧹 AWS: Deprecate createdTime in favor of createdAt Dec 1, 2024
@tas50 tas50 requested a review from misterpantz December 1, 2024 17:46
@misterpantz
Copy link
Contributor

I just made suggestions that'd make them consistent.

@tas50 tas50 requested a review from chris-rock December 2, 2024 00:45
tas50 and others added 2 commits December 9, 2024 07:51
@tas50
AWS: Deprecated createdTime in favor of createdAt
c52362d 
We use createdAt in 35 places and createTime in 6. Add createdAt to
these resources and deprecate the existing createTime.

Signed-off-by: Tim Smith <tsmith84@gmail.com>
@tas50 @misterpantz
Apply suggestions from code review
4d272a1 
Co-authored-by: Letha <letha@mondoo.com>
@tas50 tas50 force-pushed the tas50/deprecateTime branch from c22b9d6 to 4d272a1 Compare December 9, 2024 15:51
@tas50 tas50 merged commit f346eb9 into main Dec 16, 2024
17 checks passed
@tas50 tas50 deleted the tas50/deprecateTime branch December 16, 2024 17:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@misterpantz misterpantz misterpantz approved these changes

@chris-rock chris-rock chris-rock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tas50 @misterpantz @chris-rock