Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add audit log for user, add creation type and identities. #4950

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

preslavgerchev
Copy link
Contributor

@preslavgerchev preslavgerchev commented Dec 3, 2024

Adds:

  • microsoft.user.creationtype
  • microsoft.user.identities
  • microsoft.user.auditlog
    • microsoft.user.auditlog.signins
    • microsoft.user.auditlog.lastInteractiveSignIn
    • microsoft.user.auditlog.lastNonInteractiveSignIn

This comment has been minimized.

Signed-off-by: Preslav <preslav@mondoo.com>
@preslavgerchev preslavgerchev force-pushed the preslav/ms365-user-fields branch from 9e53f3e to 87da887 Compare December 3, 2024 11:54

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test Results

3 162 tests  ±0   3 161 ✅ ±0   1m 36s ⏱️ +11s
  372 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 87da887. ± Comparison against base commit a70649a.

Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only some nit picks
Thanks @preslavgerchev

providers/ms365/resources/ms365.lr Outdated Show resolved Hide resolved
providers/ms365/resources/ms365.lr Outdated Show resolved Hide resolved
providers/ms365/resources/users.go Show resolved Hide resolved
Signed-off-by: Preslav <preslav@mondoo.com>
@preslavgerchev preslavgerchev merged commit 784fb14 into main Dec 3, 2024
8 checks passed
@preslavgerchev preslavgerchev deleted the preslav/ms365-user-fields branch December 3, 2024 15:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants