Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify more of the aws resources on createdAt #5041

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Dec 26, 2024

createdAt is what Amazon uses in most of their SDK. Some of the older APIs use different values and in many cases we copied those over into our resources. This continues the work to unify all of the AWS resources on createdAt so it's easier to explore fields on resources without looking at the docs.

aws.iam.policies.first: {
  createdAt: 2022-11-27 13:27:54 -0800 PST
}

aws.iam.users.first: {
  createdAt: 2021-06-15 00:18:34 -0700 PDT
}

aws.iam.credentialReport.first: {
  createdAt: 2019-11-08 06:02:45 -0800 PST
}

aws.iam.instanceProfiles.first: {
  createdAt: 2024-07-22 11:57:13 -0700 PDT
}

aws.iam.policies.first.versions: [
  0: {
    createdAt: 2023-05-03 22:29:29 -0700 PDT
  }
  1: {
    createdAt: 2022-11-27 13:27:54 -0800 PST
  }
]

aws.iam.roles.first: {
  createdAt: 2024-06-27 13:10:34 -0700 PDT
}

Copy link
Contributor

github-actions bot commented Dec 26, 2024

Test Results

3 206 tests  ±0   3 203 ✅ ±0   1m 44s ⏱️ -4s
  379 suites ±0       3 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit 4e84592. ± Comparison against base commit 2b40eec.

♻️ This comment has been updated with latest results.

@tas50 tas50 requested a review from chris-rock December 26, 2024 19:49
@tas50 tas50 force-pushed the tas50/more_createdAt branch 4 times, most recently from bf3bb89 to 578232b Compare December 27, 2024 17:58
createdAt is what Amazon uses in most of their SDK. Some of the older
APIs use different values and in many cases we copied those over into
our resources. This continues the work to unify all of the AWS resources
on createdAt so it's easier to explore fields on resources without
looking at the docs.

Signed-off-by: Tim Smith <tsmith84@gmail.com>
@tas50 tas50 force-pushed the tas50/more_createdAt branch from 578232b to 4e84592 Compare December 27, 2024 18:03
@vjeffrey vjeffrey merged commit f8106af into main Jan 13, 2025
17 checks passed
@vjeffrey vjeffrey deleted the tas50/more_createdAt branch January 13, 2025 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants