Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 do not download providers when already present #5079

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

imilchev
Copy link
Member

@imilchev imilchev commented Jan 9, 2025

Some provider IDs didn't match between what is expected and what it actually is. This caused downloading providers that are already present on the machine. This PR fixes the issue

fixes mondoohq/cnspec#1537

Signed-off-by: Ivan Milchev <ivan@mondoo.com>
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Results

3 208 tests  ±0   3 204 ✅ ±0   1m 47s ⏱️ ±0s
  379 suites ±0       4 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit 230440b. ± Comparison against base commit e1fab55.

@imilchev imilchev merged commit 51eada7 into main Jan 9, 2025
17 checks passed
@imilchev imilchev deleted the ivan/fix-lint-providers-download branch January 9, 2025 17:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cnspec lint download providers although they are already installed
2 participants