Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2pool: Only kill p2pool if we started it #3917

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

ComputeryPony
Copy link
Contributor

Currently the GUI attempts to kill p2pool whenever it is closed, even if the instance of p2pool it is trying to kill wasn't started by it.
Changed to only kill it if we started it.

@ComputeryPony ComputeryPony changed the title Only kill p2pool if we started it p2pool: Only kill p2pool if we started it May 10, 2022
Copy link
Contributor

@devhyper devhyper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can extend the if statement to the entire method excluding the qDebug, otherwise looks good.

@ComputeryPony
Copy link
Contributor Author

Fixed and squashed, should be good now.

@luigi1111 luigi1111 merged commit 1c23ca3 into monero-project:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants