display wallet files with "." in name #3968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #3774 wallet files containing a dot not being visible was reported. @rbrunner7 also mentions that their wallet files contain ".wallet" at the end.
after i found the relevant place in the source where this is handled, selsta suggested "suffix" rather then "completeSuffix". I then noticed the full filename was still missing in the menu - using "completeBaseName" solved this
I also tested naming a wallet .keys but this is handled correctly by (assuming) wallet2 somewhere (the .keys is stripped from the cache file)