Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "magazines" section to "newsletters" and update resources at library page #2044

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

HardenedSteel
Copy link
Contributor

@HardenedSteel HardenedSteel commented Sep 12, 2022

  • Renamed "magazines" title because using "newsletters" title is more appropriate.
  • Didn't write a description for resources, if needed feel free to make suggestion.
  • Didn't include revuo-xmr.com because @erciccione pointed some issues at #1976

and it will close #1976

@netlify
Copy link

netlify bot commented Sep 12, 2022

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 95f24b5
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/64663fa55b5ad50008629017
😎 Deploy Preview https://deploy-preview-2044--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@plowsof
Copy link
Collaborator

plowsof commented Sep 12, 2022

If the moneromoons ccs proposal is not merged to funding , he will not produce the newsletter anymore , something to consider (and is currently away for the next 4 weeks)

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better add a brief description of each newsletter otherwise it's quite ugly and differs from the style of the rest of the page.

@erciccione
Copy link
Contributor

Opinions about my comment above?

@HardenedSteel
Copy link
Contributor Author

@erciccione It can be great but what should we write?

@erciccione
Copy link
Contributor

@HardenedSteel i don't know as i'm not very familiar with any of them, but even just author and structure (published every N) would be enough.

_i18n/en.yml Outdated Show resolved Hide resolved
library/index.md Outdated Show resolved Hide resolved
library/index.md Outdated Show resolved Hide resolved
@erciccione
Copy link
Contributor

ping @HardenedSteel

@plowsof
Copy link
Collaborator

plowsof commented May 25, 2023

we can merge as is OR add/test html scripting with this pull request ive made here HardenedSteel#2

@erciccione
Copy link
Contributor

I'd merge as it is, since this is already reviewed and i would open a dedicated pr after if you want to propose that patch. That said, personally i don't see the need to increase complexity and add a new file. It's only two entries, but even if it was more, the current structure could still be used without problems.

@luigi1111 luigi1111 merged commit dec0f62 into monero-project:master Jun 6, 2023
@HardenedSteel HardenedSteel deleted the patch3 branch October 16, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve Magazines section of the Library page
4 participants