Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet-generator: files renamed, signed by binaryFate, added zip. #2220

Merged

Conversation

binaryFate
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jan 14, 2024

Deploy Preview for barolo-time-757cf9 ready!

Name Link
🔨 Latest commit d1aec6d
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/65a372b83d33c30008d7540b
😎 Deploy Preview https://deploy-preview-2220--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@plowsof
Copy link
Collaborator

plowsof commented Jan 14, 2024

LGTM
looking inside resources/wallet-generator: hash of zipped html file matches + good signature (non zipped files identical). file names correct.

$ sha256sum wallet-generator.html
71cddc42897b13f6db9c283101fa88768e34d9a2219c233564e5a83802623d34  wallet-generator.html
$ gpg --verify wallet-generator.html.asc 
gpg: assuming signed data in 'wallet-generator.html'
gpg: Signature made Sat 13 Jan 2024 04:29:50 GMT
gpg:                using RSA key AD564CDA8F1665ACE78B5DFD2593838EABB1F655
gpg: Good signature from "binaryFate <binaryfate@getmonero.org>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 81AC 591F E9C4 B65C 5806  AFC3 F0AF 4D46 2A0B DF92
     Subkey fingerprint: AD56 4CDA 8F16 65AC E78B  5DFD 2593 838E ABB1 F655

Copy link
Contributor

@rbrunner7 rbrunner7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the same checks as @plowsof, and also tried whether the generator works in the first place and produces valid seeds and keys - just to be sure.

I can confirm that everything checks out. Thanks @binaryFate !

@binaryFate binaryFate merged commit 7346f7f into monero-project:master Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants