Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

press kit: add/link to quick facts 2024 johnr365 #2226

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

plowsof
Copy link
Collaborator

@plowsof plowsof commented Jan 21, 2024

quick fix for the broken monerooutreach link.

we could add "(outdated)" to the title, however this is a translated string, and could complicate things.

#2228

replaces #2189 which adds the 2018 version

Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ff13529
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/668ab77922ae0c0008a57153
😎 Deploy Preview https://deploy-preview-2226--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

press-kit/index.md Outdated Show resolved Hide resolved
@nahuhh
Copy link
Contributor

nahuhh commented Jan 21, 2024

Also agree with the [OUTDATED] or (outdated) etc added to the title

Copy link
Contributor

@nahuhh nahuhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2226 (comment)

not a blocker, but i don't particularly like it 😝

@plowsof
Copy link
Collaborator Author

plowsof commented Jul 4, 2024

we have a new quick-facts doc

https://resilience365.com/monero-quick-facts/

Johnr365 😭 ❤️

Copy link
Contributor

@nahuhh nahuhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can del 2019 pdf
and can change pr title to 2024

@plowsof plowsof changed the title press kit: add/link to quick facts 2019 pdf press kit: add/link to quick facts 2024 johnr365 Jul 4, 2024
@plowsof plowsof requested a review from nahuhh July 4, 2024 21:30
@@ -120,7 +120,7 @@ meta_descr: meta_descr.presskit
<div class="info-block">
<h2>{% t press-kit.pressdoc %}</h2>
<div>
<h3><a href="https://www.monerooutreach.org/quick-facts.html">{% t press-kit.quickfacts %}</a></h3>
<h3><a href="Monero_QuickFacts_June_2024.pdf">{% t press-kit.quickfacts %}</a></h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3><a href="Monero_QuickFacts_June_2024.pdf">{% t press-kit.quickfacts %}</a></h3>
<h3><a href="Monero_QuickFacts_June_2024.pdf">{% t press-kit.quickfacts %} (PDF)</a></h3>

does this work? - added (PDF) so people know that its a file. I assume PDF doesn't need to be translated.

otherwise, LGTM

Copy link
Collaborator Author

@plowsof plowsof Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Presenting direct link to DL/open a .pdf (especially to our audience) is, at the very least, not very courteous: see https://stackoverflow.com/a/48431884

We can also link people to the .html version hosted on johnr365's e.g. Title (PDF) / .html

*The original is the html link. Lets just do that then people can view johns site in plain text and access the printer friendly versions and such

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointing to https://resilience365.com/monero-quick-facts/ now. the pdf remains for archival purposes only.

@plowsof plowsof force-pushed the press_kit branch 2 times, most recently from 10de300 to 4e8c1a8 Compare July 5, 2024 17:13
@nahuhh
Copy link
Contributor

nahuhh commented Jul 6, 2024

pinging @HardenedSteel for a second look

Copy link
Contributor

@HardenedSteel HardenedSteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PDF file (https://resilience365.com/files/QuickFacts.pdf) is easier to read. Its better to link the PDF file instead the web page.

Why? Because its quick facts and needs to be easier to read.

@@ -120,7 +120,7 @@ meta_descr: meta_descr.presskit
<div class="info-block">
<h2>{% t press-kit.pressdoc %}</h2>
<div>
<h3><a href="https://www.monerooutreach.org/quick-facts.html">{% t press-kit.quickfacts %}</a></h3>
<h3><a href="https://resilience365.com/monero-quick-facts">{% t press-kit.quickfacts %}</a></h3>
Copy link
Contributor

@nahuhh nahuhh Jul 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3><a href="https://resilience365.com/monero-quick-facts">{% t press-kit.quickfacts %}</a></h3>
<h3><a href="https://resilience365.com/files/QuickFacts.pdf">{% t press-kit.quickfacts %} (PDF)</a></h3>

i think this is what @HardenedSteel suggests.
Linking to our hosted version would be ideal though.

I'm ok with any of them.
A) linking to html
B) linking to external PDF
C) linking to internal PDF

internal PDF:
#2226 (comment)

@nahuhh
Copy link
Contributor

nahuhh commented Jul 6, 2024

The PDF file (https://resilience365.com/files/QuickFacts.pdf) is easier to read. Its better to link the PDF file instead the web page.

Why? Because its quick facts and needs to be easier to read.

After some more thought, i think we should leave it linking to the page html page (https://resilience365.com/monero-quick-facts)

  1. To give proper credit
  2. Access to both printer friendly and full color versions

@plowsof
Copy link
Collaborator Author

plowsof commented Jul 6, 2024

The PDF file (https://resilience365.com/files/QuickFacts.pdf) is easier to read. Its better to link the PDF file instead the web page.

Why? Because its quick facts and needs to be easier to read.

i will offer some reasons as to why i disagree and favour the .html page:

  • the original linked to a .html page so its a like-for-like replacement
  • the ,html link contains the (PDF) and printer friendly version directly after landing on the page with the text based one below. this immediately presents the visitor with all available versions.
  • johnr365 voluntarily created all 3 versions of this document, and by linking to just 33% of this contribution we would also be reducing the credits that should be awarded to him for doing so
  • johnr365 is active and has a track record of 'keeping his site online / responding to issues with it promptly'

@nahuhh
Copy link
Contributor

nahuhh commented Jul 6, 2024

Also, when info is updated, we wont have to keep coming back to mirror it

(example: i plan to contact john in regards to updating the node count to match monero.fail's 12000 number)

@johnr365
Copy link

johnr365 commented Jul 6, 2024

@nahuhh - thanks, I've updated the node count to ~12,000 to match the monero.fail number.

@HardenedSteel
Copy link
Contributor

then i think that page needs to be improved, it has to be easy to read for inpatient people and newcomers

@nahuhh
Copy link
Contributor

nahuhh commented Jul 6, 2024

then i think that page needs to be improved, it has to be easy to read for inpatient people and newcomers

aside from the header, you have
the opening credits:

Prior to the Monero Outreach site going offline, they had created a Quick Facts PDF that summarized key features of Monero.

It was last updated in May 2019. Rather than let it die (source), I’ve updated it here, with full credit to Monero Outreach for the original content:

links to pdf follow the credits, and the remainder of the page is a text copy of the pdf

Copy link
Contributor

@nahuhh nahuhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving w/ external html link

@HardenedSteel
Copy link
Contributor

there's still Monero_QuickFacts_June_2024.pdf in the repo, is that ok?

@nahuhh
Copy link
Contributor

nahuhh commented Jul 7, 2024

there's still Monero_QuickFacts_June_2024.pdf in the repo, is that ok?

#2226 (comment)

@luigi1111 luigi1111 merged commit 014a91d into monero-project:master Jul 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants