'getinfo' daemon HTTP-RPC returns 'target_height' for progress estimation #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monero-project
pushed a commit
that referenced
this pull request
Jun 5, 2014
'getinfo' daemon HTTP-RPC returns 'target_height' for progress estimation
Closed
scilicet64
referenced
this pull request
in Beldex-Coin/beldex
Mar 20, 2019
Update blockchain height estimate to our fork time
lxop
pushed a commit
to lxop/monero
that referenced
this pull request
Jan 27, 2021
…ckchain-disclaimer-and-license New License
jeffro256
pushed a commit
to jeffro256/monero
that referenced
this pull request
Feb 14, 2024
…tProposals (monero-project#24) * modify construct_tx_for_mock_ledger_v1 so it outputs the JamtisPaymentProposals --------- Co-authored-by: DangerousFreedom <monero-inflation-checker@protonmail.com>
jeffro256
pushed a commit
to jeffro256/monero
that referenced
this pull request
Mar 7, 2024
…tProposals (monero-project#24) * modify construct_tx_for_mock_ledger_v1 so it outputs the JamtisPaymentProposals --------- Co-authored-by: DangerousFreedom <monero-inflation-checker@protonmail.com>
jeffro256
pushed a commit
to jeffro256/monero
that referenced
this pull request
Aug 20, 2024
…tProposals (monero-project#24) * modify construct_tx_for_mock_ledger_v1 so it outputs the JamtisPaymentProposals --------- Co-authored-by: DangerousFreedom <monero-inflation-checker@protonmail.com>
nahuhh
added a commit
to nahuhh/monero
that referenced
this pull request
Sep 4, 2024
* cryptonote: BSS new fork height * cryptonote: pre-fork BSS=100, postfork=5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution : "cryptonote_protocol_handler.inl" calls a 'core' setter for updating the target blockchain height. The "blockchain_target_height" attribute in 'core' was created for purely informative stuff. I don't think this is the best way to achieve this, but I think the core shouldn't access to raw data by itself, and it seems that some structure accessors/getters are actually performing changes to objects, so I wouldn't take the risk to alter daemon behavior.
The ideal way to achieve this properly could be an "Observer" pattern.