wallet: encrypt the cache file #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moneromooo-monero
force-pushed
the
encrypt-cache
branch
from
3259715
to
369bc0b
Compare
It contains private data, such as a record of transactions. The key is derived from the view and spend secret keys. The encryption currently is one shot, so may require a lot of memory for large wallet caches.
moneromooo-monero
force-pushed
the
encrypt-cache
branch
2 times, most recently
from
b09d8b7
to
f197599
Compare
|
It won't update to the latest commit message, but: it now uses both the view and spend secret keys to generate the chacha key. |
scilicet64
pushed a commit
to Beldex-Coin/beldex
that referenced
this pull request
Mar 20, 2019
…oject#381) * Fix switch fallthrough error after fixing export_transfers * Change the assert to a warning
scilicet64
pushed a commit
to Beldex-Coin/beldex
that referenced
this pull request
Mar 20, 2019
…oject#381) * Fix switch fallthrough error after fixing export_transfers * Change the assert to a warning
scilicet64
pushed a commit
to Beldex-Coin/beldex
that referenced
this pull request
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It contains private data, such as a record of transactions.
The key is derived from the view secret key.
The encryption currently is one shot, so may require a lot of
memory for large wallet caches.