-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix build with Boost 1.85 and remove instances of viewkey logging [RELEASE] #9462
build: fix build with Boost 1.85 and remove instances of viewkey logging [RELEASE] #9462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I can build v0.18.3.4 on macOS by applying this PR, but I'm still getting this error building monero-cpp, when importing cryptonote_basic/account.h:
Any ideas? |
Found the fix, to add |
…ing [RELEASE] 1. Use std::is_standard_layout and std::is_trivially_copyable instead of std::is_pod for KV byte-wise serialization, which fixes compile issue for Boost UUIDs 2. Removed reimplementation of std::hash for boost::uuids::uuid 3. Removed << operator overload for crypto::secret_key 4. Removed instances in code where private view key was dumped to the log in plaintext Release version of monero-project#9450, containing C++14 modified assertions
131ac93
to
65568d3
Compare
Any chance we could merge this PR to the release branch, to fix the build for folks on macOS? Otherwise our build is broken, which is making development of PRs across people difficult. |
std::is_standard_layout
andstd::is_trivially_copyable
instead ofstd::is_pod
for KV byte-wise serialization, which fixes compile issue for Boost UUIDsstd::hash
forboost::uuids::uuid
<<
operator overload forcrypto::secret_key
Release version of #9450