Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: make boost 1.58 minimum requirement. Fixes #956 #964

Merged
merged 1 commit into from
Aug 22, 2016

Conversation

anonimal
Copy link
Contributor

Personally, I would hold off on merging this until #951 and related documentation are resolved.

I have a feeling if #951 isn't resolved by the same time this is merged, there will be swarm of complaints about the build (e.g., any Debian stable users who don't know how to use apt-get, etc.).

@grummerd
Copy link

Would like to confirm both libboost1.58-dev and libboost1.58-tools-dev are available in the Ubuntu universal repository. So can go ahead and make it a minimal version

@moneromooo-monero
Copy link
Collaborator

Would it be much work to make it require 1.58 only for CLANG (since AFAIK it's only CLANG that requires it) ? 1.58 seems a bit new (about a year old), but if it's too annoying to make conditional, I'm fine with the patch.

@anonimal
Copy link
Contributor Author

@moneromooo-monero if you look at #956, you'll see that its not just about clang but rather kovri too.

@moneromooo-monero
Copy link
Collaborator

Yes, I know kovri requires that, but since it's separate for now, I think bumping to 1.58 represents a gratuitous denial of build since it'd work just fine (assuming the user has GCC). Again, no strong opinion about it.

@anonimal
Copy link
Contributor Author

Good point, but FreeBSD packages boost 1.55.0 and clang 3.4.1 by default. Is anyone actively developing BSD builds?

@fluffypony fluffypony merged commit 2a2b655 into monero-project:master Aug 22, 2016
fluffypony added a commit that referenced this pull request Aug 22, 2016
2a2b655 Build: make boost 1.58 minimum requirement. Fixes #956 (anonimal)
@anonimal anonimal deleted the boost-1.58 branch August 22, 2016 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants