fix: Allow import of devDependency modules in Storybook files #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tongari07
reviewed
May 24, 2024
tongari07
requested changes
May 24, 2024
Co-authored-by: Naoto Togawa@こまちょ <52874708+tongari07@users.noreply.github.com>
oss-frontend-github-app bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
# [4.0.0](3.0.0...4.0.0) (2024-06-20) ### Bug Fixes * `import/namespace` error ([#294](#294)) ([a512fed](a512fed)) * Allow import of devDependency modules in Storybook files ([#279](#279)) ([1503dbe](1503dbe)) * Resolve the problem of incorrect recognition of alias path by TypeScript's Compiler Options ([#293](#293)) ([39c4f0a](39c4f0a)) * Specify `jest` as a Peer Dependency ([#298](#298)) ([4f750da](4f750da)) ### Features * Implement the Flat Config ([#300](#300)) ([0a16caf](0a16caf)) * Remove deprecated rule settings ([#295](#295)) ([b264582](b264582)) * Update ESLint version requirement ([#272](#272)) ([e2e952a](e2e952a)) * Update eslint-plugin-jest version ([#275](#275)) ([9f31624](9f31624)) * Update eslint-plugin-n version ([#274](#274)) ([5e5ce78](5e5ce78)) * Update eslint-plugin-testing-library version ([#277](#277)) ([9d23602](9d23602)) * Update Node.js version requirement ([#271](#271)) ([44d7fe3](44d7fe3)) * Update typescript-eslint version ([#273](#273)) ([64042cb](64042cb)) ### BREAKING CHANGES * [Update eslint-plugin-testing-library version to 6 higher](https://github.com/testing-library/eslint-plugin-testing-library/releases/tag/v6.0.0) * Update the TypeScript peer dependency requirement to `>= 4.7.5 || ^5.0.0`. This means we are dropping support for TypeScript 4 versions prior to `4.7.5`. * fix version * Update the ESLint peer dependency requirement to `^8.56.0`. This means we are dropping support for ESLint 8 versions prior to `8.56.0`. * chore: specify eslint version in ci only v8 * Update Node.js engine requirement to `>= 18.18.0 || >= 20.0.0`. This means we are dropping support for Node 18 versions prior to `18.18.0`.
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Storybook related files need to import devDependency modules. Therefore, we need to modify ESLint's import rule to allow this.
References