Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import/no-extraneous-dependencies #357

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

wakamsha
Copy link
Contributor

What changed / motivation ?

import/no-extraneous-dependencies is a rule that prohibits the import of modules that are not listed in dependencies field of package.json.

In other words, it also prohibits the import of modules listed in the devDependencies field, but since toolchain-related configuration files need to import them, we decided to allow the import of them.

https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-extraneous-dependencies.md

The current rule settings don't allow the import of eslint.config.* or vite.config.ts, so I have modified the rule settings.

Linked PR / Issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Chore (routine task, maintenance, or non-functional change that doesn't modify src or test files)

Pre-flight checklist

References

@wakamsha wakamsha self-assigned this Dec 16, 2024
Copy link
Contributor

@tongari07 tongari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

@wakamsha wakamsha merged commit 3f9dd7e into main Dec 17, 2024
2 checks passed
@wakamsha wakamsha deleted the fix/no-extraneus-depedencies branch December 17, 2024 13:10
oss-frontend-github-app bot pushed a commit that referenced this pull request Dec 17, 2024
## [5.0.1](5.0.0...5.0.1) (2024-12-17)

### Bug Fixes

* import/no-extraneous-dependencies ([#357](#357)) ([3f9dd7e](3f9dd7e))
@oss-frontend-github-app
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants