Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update typescript-eslint version #273

Merged
merged 2 commits into from
May 23, 2024

Conversation

wakamsha
Copy link
Contributor

@wakamsha wakamsha commented May 21, 2024

BREAKING CHANGE:

Update the TypeScript peer dependency requirement to >= 4.7.5 || ^5.0.0. This means we are dropping support for TypeScript 4 versions prior to 4.7.5.

Features

Support typescript-eslint version to ^7.10.0.

Context

v7 of typescript-eslint requires ESLint v8.56.0 and Node.js v18.18.0. This update is possible because #271 and #272 change the minimum version of them.

References

@wakamsha wakamsha self-assigned this May 21, 2024
@wakamsha wakamsha force-pushed the feat/update-typescript-eslint-version branch from 3238e6a to 35a8da3 Compare May 22, 2024 04:34
BREAKING CHANGE:

Update the TypeScript peer dependency requirement to `>= 4.7.5 || ^5.0.0`. This means we are dropping support for TypeScript 4 versions prior to `4.7.5`.
@wakamsha wakamsha force-pushed the feat/update-typescript-eslint-version branch from 35a8da3 to 5d6cf98 Compare May 22, 2024 08:31
@wakamsha wakamsha marked this pull request as ready for review May 22, 2024 08:36
package.json Outdated
Comment on lines 36 to 37
"@typescript-eslint/eslint-plugin": "^7.0.0",
"@typescript-eslint/parser": "^7.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each package has been released as v7.10.0, how about update to the latest version?

https://www.npmjs.com/package/@typescript-eslint/eslint-plugin
https://www.npmjs.com/package/@typescript-eslint/parser

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: 1802efc

@wakamsha wakamsha requested a review from tongari07 May 23, 2024 06:54
Copy link
Contributor

@tongari07 tongari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wakamsha wakamsha merged commit 64042cb into main May 23, 2024
3 checks passed
@wakamsha wakamsha deleted the feat/update-typescript-eslint-version branch May 23, 2024 09:27
oss-frontend-github-app bot pushed a commit that referenced this pull request Jun 20, 2024
# [4.0.0](3.0.0...4.0.0) (2024-06-20)

### Bug Fixes

* `import/namespace` error ([#294](#294)) ([a512fed](a512fed))
* Allow import of devDependency modules in Storybook files ([#279](#279)) ([1503dbe](1503dbe))
* Resolve the problem of incorrect recognition of alias path by TypeScript's Compiler Options ([#293](#293)) ([39c4f0a](39c4f0a))
* Specify `jest` as a Peer Dependency ([#298](#298)) ([4f750da](4f750da))

### Features

* Implement the Flat Config ([#300](#300)) ([0a16caf](0a16caf))
* Remove deprecated rule settings ([#295](#295)) ([b264582](b264582))
* Update ESLint version requirement ([#272](#272)) ([e2e952a](e2e952a))
* Update eslint-plugin-jest version ([#275](#275)) ([9f31624](9f31624))
* Update eslint-plugin-n version ([#274](#274)) ([5e5ce78](5e5ce78))
* Update eslint-plugin-testing-library version ([#277](#277)) ([9d23602](9d23602))
* Update Node.js version requirement ([#271](#271)) ([44d7fe3](44d7fe3))
* Update typescript-eslint version ([#273](#273)) ([64042cb](64042cb))

### BREAKING CHANGES

* [Update eslint-plugin-testing-library version to 6 higher](https://github.com/testing-library/eslint-plugin-testing-library/releases/tag/v6.0.0)
* Update the TypeScript peer dependency requirement to `>= 4.7.5 || ^5.0.0`. This means we are dropping support for TypeScript 4 versions prior to `4.7.5`.

* fix version
* Update the ESLint peer dependency requirement to `^8.56.0`. This means we are dropping support for ESLint 8 versions prior to `8.56.0`.

* chore: specify eslint version in ci only v8
* Update Node.js engine requirement to `>= 18.18.0 || >= 20.0.0`. This means we are dropping support for Node 18 versions prior to `18.18.0`.
@oss-frontend-github-app
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants