Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @pkgjs/nv for version resolution #5

Closed
wesleytodd opened this issue Nov 2, 2020 · 2 comments · Fixed by #6
Closed

Use @pkgjs/nv for version resolution #5

wesleytodd opened this issue Nov 2, 2020 · 2 comments · Fixed by #6

Comments

@wesleytodd
Copy link
Contributor

Would you be interested in using this package to do the resolution? It supports semver ranges like you have, but also all of the aliases the Package Maintenance Team is working to standardize on.

https://github.com/pkgjs/nv/
@addaleax
Copy link
Contributor

addaleax commented Nov 2, 2020

Yeah, that sounds like something that would make sense. Do you want to submit a PR? 🙂

@wesleytodd
Copy link
Contributor Author

Sure thing, 🤞 that I can quickly and that it works alright in TypeScript projects.

wesleytodd added a commit to wesleytodd/boxednode that referenced this issue Nov 2, 2020
@wesleytodd
feat: use @pkgjs/nv for node version resolutions; adds alias support (c…
4a40ba3 
…loses mongodb-js#5)
addaleax added a commit to wesleytodd/boxednode that referenced this issue Nov 2, 2020
@addaleax
fixup! feat: use @pkgjs/nv for node version resolutions; adds alias s…
5431925 
…upport (closes mongodb-js#5)
@addaleax addaleax mentioned this issue Nov 2, 2020
Merged
addaleax pushed a commit that referenced this issue Nov 2, 2020
@wesleytodd
Use @pkgjs/nv for node version resolutions (#6)
8819ae6 
Fixes: #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use @pkgjs/nv for node version resolutions wesleytodd/boxednode
2 participants
@addaleax @wesleytodd